Skip to content

merge latest 4.8.2B#3936

Closed
softboy99 wants to merge 6 commits intobinarywang:developfrom
softboy99:develop
Closed

merge latest 4.8.2B#3936
softboy99 wants to merge 6 commits intobinarywang:developfrom
softboy99:develop

Conversation

@softboy99
Copy link
Contributor

merge latest 4.8.2B

softboy99 and others added 6 commits March 11, 2026 09:34
merge latest from fork source
…参数不符合系统要求,需要参照具体API接口说明,微信原始报文:{"errcode":40058,"errmsg":"invalid Request Parameter
…rvice.java

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…pHrServiceImpl.java

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…rvice.java

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@augmentcode
Copy link

augmentcode bot commented Mar 18, 2026

🤖 Augment PR Summary

Summary: Updates the WeCom HR (人事助手) staff info wrapper to match recent API changes.

Changes: Tweaks interface docs and extends the /cgi-bin/hr/get_staff_info request payload to include a get_all flag (adding a new overload in the impl).

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 3 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.


/**
* 获取员工档案数据.
* <p>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This newly-added Javadoc for hr/get_staff_info appears to be attached to the updateEmployeeFieldInfo section (and 权限说明: is left blank), so the interface docs read inconsistently/misleadingly.

Severity: low

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.


@Override
public WxCpHrEmployeeFieldDataResp getEmployeeFieldInfo(String userid, boolean getAll, List<String> fields) throws WxErrorException {
if (userid == null || userid.trim().isEmpty()) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WxCpHrService currently doesn’t declare getEmployeeFieldInfo(String, boolean, List), so this @Override overload won’t compile / won’t be reachable via the interface type.

Severity: high

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

@Override
public WxCpHrEmployeeFieldDataResp getEmployeeFieldInfo(String userid, List<String> fields) throws WxErrorException {
return getEmployeeFieldInfo(userid,false,fields);
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Defaulting the 2-arg getEmployeeFieldInfo to getAll=false means callers passing null/empty fields will send get_all=false without a field list; the official get_staff_info doc indicates the field list must be non-empty in that case, so this may start returning errors.

Severity: medium

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

@binarywang
Copy link
Owner

啥也没改吗?

@softboy99
Copy link
Contributor Author

忽略这个PR, 你的类结构很复杂哦,和微信官方接口的对应关系搞不清楚,还是大佬自己来吧

@binarywang binarywang closed this Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants