This repository was archived by the owner on Jul 14, 2023. It is now read-only.
Fixed issue where error was thrown when message body is not JSON#10
Open
johndierks wants to merge 4 commits intobigluck:masterfrom
Open
Fixed issue where error was thrown when message body is not JSON#10johndierks wants to merge 4 commits intobigluck:masterfrom
johndierks wants to merge 4 commits intobigluck:masterfrom
Conversation
|
Any possibility we could get this merged? Thanks! |
|
@bigluck Checking back in to see if we could get this merged and published. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In cases where the message's body is not JSON, trying to parse the body as JSON throws an error and crashes the process.
To prevent this from happening, we can attempt to parse the message body in a try block. If the message is not valid JSON, the catch block catches the error and then assigns the raw message string as the data.