eng: Add client helpers to the generated template for alpha and beta endpoints BNCH-111588#228
Open
tara-natarajan wants to merge 11 commits intoprod/2.xfrom
Open
eng: Add client helpers to the generated template for alpha and beta endpoints BNCH-111588#228tara-natarajan wants to merge 11 commits intoprod/2.xfrom
tara-natarajan wants to merge 11 commits intoprod/2.xfrom
Conversation
tara-natarajan
changed the title
tara-natarajan
changed the title
| return client | ||
|
|
||
|
|
||
| def v3_stable_client(client: Client) -> Client: |
There was a problem hiding this comment.
Is there any reason we want to expose these in a lowish level library rather than in benchling-sdk? IIRC there's some "invariant" code that doesn't get generated that can be referenced from generated code. Could that be another location for this?
This is far too specific to our use of APIs to include in this library. Any functionality we write should be general to APIs. You could argue that replace_client_path could live here but... something tells me there ought to be a way to specify this in the caller (in benchling-sdk) instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the client.py file to include helper functions to update the client url to use the alpha and beta endpoints.