OpenPGP - Partial length encoding: Enforce minimum length of the first chunk#1828
Draft
vanitasvitae wants to merge 1 commit intobcgit:mainfrom
Draft
OpenPGP - Partial length encoding: Enforce minimum length of the first chunk#1828vanitasvitae wants to merge 1 commit intobcgit:mainfrom
vanitasvitae wants to merge 1 commit intobcgit:mainfrom
Conversation
Contributor
Author
|
This patch currently breaks with a (broken) test vector from Edit: Apparently there are more broken test vectors, and it appears to be easily possible to generate broken messages via too short partial encoding. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OpenPGP specification mandates that if partial body encoding is used, the first chunk must be at least 512 bytes long.
Currently, BC does not enforce this requirement (see https://tests.sequoia-pgp.org/#Tests_support_for_partial_body_encoding )
This PR adds a check for this requirement, which will throw an
IOExceptionfor malformed packets.