fix(system_python): backport Debian 10 Buster bug into 2.0.2#3782
fix(system_python): backport Debian 10 Buster bug into 2.0.2#3782limdor wants to merge 1 commit into
Conversation
This attribute is not part of the Python public API and in Debian 10 Buster (OpenJDK 11, gcc 8.3.0) it seems to not be defined. This reverts one of the debug logging statements added in bazel-contrib#3667 Fixes bazel-contrib#3774
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request fixes an AttributeError on Debian 10 Buster and removes a verbose print statement for sys._base_executable in the bootstrap template. The reviewer suggested updating the placeholder version 0.0.0 in the CHANGELOG.md to 2.0.2 to ensure consistency with the pull request title and the intended release version.
| {#v0-0-0} | ||
| ## Unreleased | ||
|
|
||
| [0.0.0]: https://github.com/bazel-contrib/rules_python/releases/tag/0.0.0 |
There was a problem hiding this comment.
The PR title mentions a backport into version 2.0.2. However, the added changelog section uses the placeholder version 0.0.0 and anchor {#v0-0-0} from the template. If the target version for this release is known to be 2.0.2, it would be clearer to use that version number explicitly in the anchor and link definition to avoid confusion and ensure correct linking once released.
| {#v0-0-0} | |
| ## Unreleased | |
| [0.0.0]: https://github.com/bazel-contrib/rules_python/releases/tag/0.0.0 | |
| {#v2-0-2} | |
| ## Unreleased | |
| [2.0.2]: https://github.com/bazel-contrib/rules_python/releases/tag/2.0.2 |
1 participant
This attribute is not part of the Python public API and in Debian 10 Buster (OpenJDK 11, gcc 8.3.0) it seems to not be defined.
This reverts one of the debug logging statements added in #3667
Fixes #3774