chore!: drop WORKSPACE support from rules_python#3780
Draft
aignas wants to merge 3 commits into
Draft
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request focuses on the deprecation and removal of legacy WORKSPACE support in favor of bzlmod for PyPI dependency management. It includes the deletion of several WORKSPACE files across examples, updates to documentation to reflect the shift, and the removal of WORKSPACE-specific logic and symbols from the core build rules. Additionally, the PR applies minor formatting improvements to various Python scripts throughout the repository. I have no feedback to provide.
dougthor42
reviewed
May 16, 2026
| baz import ( | ||
| baz | ||
| ) | ||
| from foo.bar.baz import baz |
Collaborator
There was a problem hiding this comment.
Looks like autoformatting snuck in.
Either wrap in # fmt: off # fmt: on comments, or tell formatter to ignore this file. This one is intentionally asserting some python AST parsing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All of the bazel versions that we support support
bzlmodand the support forWORKSPACEis being dropped in other rulesets as well. At some point newversions of our dependencies will make it more and more difficult to carry
support for both, so in order to make the codebase easier to maintain, let's
drop the support.
Regarding whether we should call the next version 2.1 or 3.0, I am not sure.
For
bzlmodusers nothing is changing, so Semver is respected, whereas forWORKSPACEusers,rules_pythoncannot be used anymore, it's as if 2.1 nolonger exists for
WORKSPACEusers, so I think it is fine to call the release2.1.
Summary:
Work towards #2950