Skip to content

⚡ Optimize submodule lookup by avoiding redundant string clones #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bashandbone wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡ Optimize submodule lookup by avoiding redundant string clones #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions src/git_ops/git2_ops.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,13 +215,7 @@ impl GitOperations for Git2Operations {
if let Some(submodules) = config.submodules().as_ref() {
for (name, entry) in submodules.iter() {
// Find or create the submodule
match self.repo.find_submodule(
&entry
.path
.as_ref()
.map(|p| p.to_string())
.unwrap_or(name.clone()),
) {
match self.repo.find_submodule(entry.path.as_deref().unwrap_or(name)) {
Ok(mut submodule) => {
// Update existing submodule configuration through git config
let mut config = self.repo.config()?;
Expand Down