Fix self-demo BATS fixture path portability#1323
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
base-bash-libspath in the self-demo BATS pause test with the existing portable fixture resolver.Root Cause
The self-demo pause test used
/Users/rameshhp/work/base-bash-libs/lib/bashas a fallbackBASE_BASH_LIBS_DIR. That works on the primary macOS checkout but fails on fresh Ubuntu source checkouts, so the test exits before exercising the terminal-fd pause behavior.Validation
PYTHONPATH=/Users/rameshhp/work/base/lib/python:/Users/rameshhp/work/base/cli/python /Users/rameshhp/.base.d/base/.venv/bin/python -m pytest tests/test_contract_hardening.py -qbats cli/bash/commands/basectl/tests/demo.batsgit diff --checkenv -u BASE_HOME ./bin/base-test-> Python731 passed, 1 skipped; BATS569 okFixes #1322