fix _loadVerified assembly offsets in CertManager#37
Open
Sertug17 wants to merge 1 commit into
Open
Conversation
_loadVerified was reading fields from wrong byte offsets in the packed certificate metadata. abi.encodePacked lays out the fields as: ca(1) || notAfter(8) || maxPathLen(8) || subjectHash(32) || pubKey(48) But the assembly code was reading from offset 0x1 for ca (should be 0x0), 0x9 for notAfter (should be 0x1), 0x11 for maxPathLen (should be 0x9), and 0x31 for subjectHash (should be 0x11). Only pubKey was correct since it uses slice(). The warm cache path reads cert metadata with these wrong offsets, so every cached cert would get garbage values for ca, notAfter, maxPathLen and subjectHash.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_loadVerified was reading fields from wrong byte offsets in the packed certificate metadata. abi.encodePacked lays out the fields as: