fix(docs): remove .mdx extension from signInWithEthereum link#1348
Open
HusseinAdeiza wants to merge 2 commits intobase:masterfrom
Open
fix(docs): remove .mdx extension from signInWithEthereum link#1348HusseinAdeiza wants to merge 2 commits intobase:masterfrom
HusseinAdeiza wants to merge 2 commits intobase:masterfrom
Conversation
Fixes base#1313 The JSON response example in agent-builder-codes.mdx contained a trailing comma after the last property, which is invalid JSON. This fix removes the comma to ensure the example shows valid JSON.
Fixes base#1311 The link to signInWithEthereum incorrectly included .mdx extension which resulted in 404 errors. Removed extension to fix navigation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1311
Removes
.mdxextension from signInWithEthereum link in wallet_connect reference documentation.Changes
docs/base-account/reference/core/provider-rpc-methods/wallet_connect.mdx.mdxextension from link pathDetails
The link to signInWithEthereum capability documentation incorrectly included the
.mdxfile extension, resulting in 404 errors when users clicked the link.Before:
/base-account/reference/core/capabilities/signInWithEthereum.mdx→ 404After:
/base-account/reference/core/capabilities/signInWithEthereum→ ✅Testing