Refactor Storybook theme sync to remove script injection and improve security#1346
Open
yasnazariel wants to merge 1 commit intobase:masterfrom
Open
Refactor Storybook theme sync to remove script injection and improve security#1346yasnazariel wants to merge 1 commit intobase:masterfrom
yasnazariel wants to merge 1 commit intobase:masterfrom
Conversation
…ybook preview - Removed script injection anti-pattern from decorator - Added React-based message listener using useEffect - Improved security by validating message payload - Added cleanup to prevent memory leaks - Improved maintainability and alignment with Storybook best practices
Collaborator
🟡 Heimdall Review Status
|
|
Great |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the Storybook preview theme synchronization logic to remove script injection and replace it with a React-based approach.
Changes
<script>injection from Storybook decoratorsuseEffect-based message listenerpostMessageeventsclassList.toggleWhy this matters
The previous implementation:
The new approach:
Type of change
Testing