fix: prevent index overwrite and improve scanDocs merging logic#1342
Open
yasnazariel wants to merge 1 commit intobase:masterfrom
Open
fix: prevent index overwrite and improve scanDocs merging logic#1342yasnazariel wants to merge 1 commit intobase:masterfrom
yasnazariel wants to merge 1 commit intobase:masterfrom
Conversation
…security - Prevent multiple load event listeners from being attached to iframes - Improve security by using a specific target origin instead of '*' - Reduce unnecessary repeated processing
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue in scanDocs where directory entries could be overwritten during recursion.
Changes
Why
The previous implementation could overwrite entries when multiple directories produced the same key, leading to data loss.
Impact