Fix broken Solidity snippet (callback example did not compile)#1129
Open
Meesut0 wants to merge 1 commit intobase:masterfrom
Open
Fix broken Solidity snippet (callback example did not compile)#1129Meesut0 wants to merge 1 commit intobase:masterfrom
Meesut0 wants to merge 1 commit intobase:masterfrom
Conversation
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
The intermediate callback snippet (lines 211–218) did not compile due to incorrect variable names used inside the function body.
The function parameters were defined as
_nonceand_rngList, but the snippet referencednonceandrngList, resulting in multipleDeclarationError: Undeclared identifier errors.How has it been tested?
Steps taken:
Remix IDErngList>_rngListnonce>_nonceThe snippet is now consistent with the final contract example and compiles correctly.