feat: Add Task to Switch to Permissioned Game and Blacklist Addresses#489
feat: Add Task to Switch to Permissioned Game and Blacklist Addresses#489
Conversation
…lacklist-games-template
🟡 Heimdall Review Status
|
setup-templates/template-switch-to-permissioned-game-blacklist/script/fetch_dispute_games.py
Outdated
Show resolved
Hide resolved
|
Can you add a |
|
|
||
| import {Vm} from "forge-std/Vm.sol"; | ||
| import {stdJson} from "forge-std/StdJson.sol"; | ||
| import {IMulticall3} from "forge-std/interfaces/IMulticall3.sol"; |
There was a problem hiding this comment.
I think the multicall import is unused
| @@ -0,0 +1,30 @@ | |||
| OP_COMMIT= | |||
| ADDRESSES_TO_BLACKLIST= | ||
|
|
||
| # Mainnet Config | ||
| SYSTEM_CONFIG=0x73a79Fab69143498Ed3712e519A88a918e1f4072 |
There was a problem hiding this comment.
Can remove this - it is automatically included from the network .env files now
| DISPUTE_GAME_FACTORY=0x43edB88C4B80fDD2AdFF2412A7BebF9dF42cB40e | ||
| SENDER=0x1822b35B09f5ce1C78ecbC06AC0A4e17885b925e | ||
|
|
||
| # # Sepolia Config |
There was a problem hiding this comment.
Can remove this entire sepolia config section
| @@ -0,0 +1,64 @@ | |||
| # Switch to Permissioned Game and Blacklist Addresses | |||
|
|
|||
| Status: PENDING | |||
There was a problem hiding this comment.
Status can be READY TO SIGN
| include ../.env | ||
| include .env | ||
|
|
||
| ifndef LEDGER_ACCOUNT |
There was a problem hiding this comment.
Can remove this LEDGER_ACCOUNT logic
| .PHONY: find-dispute-games-offchain | ||
| find-dispute-games-offchain: pip-install | ||
| RPC_URL=$(RPC_URL) DISPUTE_GAME_FACTORY=$(DISPUTE_GAME_FACTORY) L2_DIVERGENCE_BLOCK_NUMBER=$(L2_DIVERGENCE_BLOCK_NUMBER) \ | ||
| python3 script/fetch_dispute_games.py |
There was a problem hiding this comment.
This won't work - there isn't a local python script anymore
| ifndef LEDGER_ACCOUNT | ||
| override LEDGER_ACCOUNT = 0 | ||
| endif | ||
|
|
There was a problem hiding this comment.
Can we define SENDER here dynamically? See https://github.com/base/contract-deployments/blob/main/setup-templates/template-pause-superchain-config/Makefile#L10 for reference
| mkdir validations; \ | ||
| cd $(SIGNER_TOOL_PATH); \ | ||
| npm ci; \ | ||
| bun run scripts/genValidationFile.ts --rpc-url $(RPC_URL) \ |
There was a problem hiding this comment.
Can use a macro here from #629 (if it gets merged)
| $(SCRIPT_NAME) --sig "sign(address[])" ["$(OP_SECURITY_COUNCIL_SAFE)"] --sender $(SENDER)' --out ../validations/op-signer.json; | ||
|
|
||
| .PHONY: approve-op | ||
| approve-op: |
There was a problem hiding this comment.
Let's remove the -op suffix
3 participants
This PR introduces a new template to switch our
respectedGameTypeto a Permissioned game and allows us to blacklist specific games.Only the op security council can sign for this task.