Open
Conversation
By default, Github's API returns 30 results per page for 'list' requests; this cuts off old Google Java Format releases, including any that run on Java 8. 100 is the maxmimum. There are 42 releases at time of writing, so this happens to let them all through.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This action isn't able to run on Java 8 because it only sees the Github API's default of the 30 latest formatter releases. There are 42 releases currently, and the list cuts off at version 1.11.0 (JDK 11+).
This branch starts with the commits from #40, then increases the number of releases requested so any release can be used with the action:
?per_page=100(the maximum) to the end of everythingThe curl version is clunky, but the API allows page length even for /latest:
I think it could be possible to use Octokit in the no-token case, too, with something like this: j-emmel@a409c3b
Resolves: #39
Resolves: #44