This repository was archived by the owner on May 21, 2025. It is now read-only.
Remove Dependencies and Duplicated Code#65
Open
kyleyost19 wants to merge 2 commits intoawslabs:masterfrom
Open
Remove Dependencies and Duplicated Code#65kyleyost19 wants to merge 2 commits intoawslabs:masterfrom
kyleyost19 wants to merge 2 commits intoawslabs:masterfrom
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
The last comment on #22 is relevant
Description of changes:
http.Handler, so there is no need to couple this project with those routers. Let the users of this library choose what router and version they want to use.httpadapterpackage toproxyand everything else is left in tact. Obviously this is a breaking change, but I left all the other code as unchanged as possibleBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.