Skip to content

fix: replace bare except with except Exception (E722) #5657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
harshadkhetpal wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: replace bare except with except Exception (E722) #5657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sagemaker-train/src/sagemaker/train/common_utils/finetune_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,7 +446,7 @@ def _resolve_model_and_name(model, sagemaker_session=None):
try:
import boto3
region_name = boto3.Session().region_name or os.environ.get('AWS_DEFAULT_REGION')
except:
except Exception:
pass

if isinstance(model, str):
Expand Down
4 changes: 2 additions & 2 deletions sagemaker-train/src/sagemaker/train/evaluate/execution.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -904,7 +904,7 @@ def wait(
if ipython is not None and 'IPKernelApp' in ipython.config:
is_jupyter = True
from IPython.display import display, HTML, clear_output
except:
except Exception:
pass

if is_jupyter:
Expand Down Expand Up @@ -958,7 +958,7 @@ def wait(
end = datetime.fromisoformat(step.end_time.replace('Z', '+00:00'))
duration_seconds = (end - start).total_seconds()
duration = f"{duration_seconds:.1f}s"
except:
except Exception:
duration = "N/A"
elif step.start_time:
duration = "Running..."
Expand Down
Loading