Open
Conversation
mollyheamazon
approved these changes
Mar 19, 2026
| return {k: v for k, v in kwargs.items() if v is not None} | ||
|
|
||
| # Build resources | ||
| if self.instance_type is None: |
Collaborator
mollyheamazon
requested changes
Mar 19, 2026
Collaborator
mollyheamazon
left a comment
There was a problem hiding this comment.
The efa field naming change looks good.
The other fix in the PR is that it removes the node_count vs resources mutual exclusivity check. This was discussed in thread link — please confirm with the stakeholders to align with this approach given the quota implications, or if you'd prefer we introduce --num-replicas instead.
Member
Author
|
Scoped this PR down to just the EFA field rename (#306) and template rendering tests. I'll open a separate PR for the |
21382e9 to
80b5443
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changing and why?
Closes #306
The v1.1 schema and model defined EFA fields as
efa_interfaces/efa_interfaces_limit, but the jinja template usedefa/efa_limit. This caused:efain config YAML to be rejected by validation ("Extra inputs are not permitted")efa_interfacesin config YAML to pass validation but not render in the templateStandardized on
efa/efa_limitto match the naming pattern of other resource fields (accelerators,vcpu,memory) and the Kubernetes resource key (vpc.amazonaws.com/efa).Before/After UX
Before:
Specifying
efain config.yaml fails validation:Specifying
efa_interfacespasses validation but is silently ignored in the rendered YAML.After:
EFA renders correctly in the K8s YAML:
How was this change tested?
Are unit tests added?
Yes. Added
TestJinjaTemplateRenderingwith two tests that render the jinja template directly and verify all resource fields (accelerators, vcpu, memory, efa, accelerator partitions, etc.) appear correctly in the output. This catches the class of bug where schema field names drift from template variable names.Are integration tests added?
N/A
Reviewer Guidelines
One of the following must be true: