[Bug-Fix] Fix S3 multipart copy requiring s3:GetObjectVersion on versioned buckets#3867
Open
kai-ion wants to merge 3 commits into
Open
[Bug-Fix] Fix S3 multipart copy requiring s3:GetObjectVersion on versioned buckets#3867kai-ion wants to merge 3 commits into
kai-ion wants to merge 3 commits into
Conversation
Stop auto-pinning the HeadObject-derived versionId onto UploadPartCopy requests in S3CrtClient::PopulateCopyObjectProperties. Rely on the ETag conditional (x-amz-copy-source-if-match) for source consistency instead. GetObjectAnnotation and GetObjectTagging continue to use versionId since they don't support ETag conditionals.
sbiscigl
reviewed
Jul 15, 2026
| // Detect source mutation via ETag conditional without requiring s3:GetObjectVersion. | ||
| // If the user explicitly provided sourceVersionId, it is already parsed above and preserved. | ||
| if (sourceVersionId.empty() && !head.GetVersionId().empty()) { | ||
| sourceVersionId = head.GetVersionId(); |
Collaborator
There was a problem hiding this comment.
you should remove this entire if statement. we want to honor the versionId set in the request, however not override it by the head response if it present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Stop auto-pinning the HeadObject-derived versionId onto UploadPartCopy
requests in S3CrtClient::PopulateCopyObjectProperties. Rely on the ETag
conditional (x-amz-copy-source-if-match) for source consistency instead.
GetObjectAnnotation and GetObjectTagging continue to use versionId since
they don't support ETag conditionals.
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.