Fix configure set handling of profile-prefixed dotted varnames#10323
Open
mohitkum4r wants to merge 2 commits into
Open
Fix configure set handling of profile-prefixed dotted varnames#10323mohitkum4r wants to merge 2 commits into
mohitkum4r wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug (Issue #10313) where
aws configure setmishandles profile-prefixed dotted varnames.When executing a command like
aws configure set emr-dev.emr.instance_profile my_ip(whereemr-devis an existing profile), the command previously failed to recognizeemr-devas the target profile. Instead, it would write to the[default]profile, mapping the keyemr-devtomy_ip.The Fix:
I've updated
awscli/customizations/configure/set.pyto mirror the profile detection logic currently used byconfigure get(get.py). When parsing a dotted varname, it now explicitly checks if the first segment isdefaultor exists within the session's loadedprofilesconfiguration. If a match is found, it correctly assigns the value to that specific nested profile section.This ensures the syntax for reading and writing profile-scoped multi-part variables is perfectly symmetrical.
Testing
test_set.pymimicking theFakeSessionsetup fromtest_get.py.pytest tests/unit/customizations/configure/ tests/functional/configure/Resolves #10313.