Skip to content

Accept npm scopes with capital letters in CodeArtifact login#10321

Open
FiveSlashNine wants to merge 1 commit into
aws:developfrom
FiveSlashNine:develop
Open

Accept npm scopes with capital letters in CodeArtifact login#10321
FiveSlashNine wants to merge 1 commit into
aws:developfrom
FiveSlashNine:develop

Conversation

@FiveSlashNine
Copy link
Copy Markdown
Contributor

Issue #, if available:
#10207

Note:

Npm warns against using uppercase characters in scope names but doesn't block users from doing so. Although newer packages should only have lowercase scope names for several reasons (e.g., case sensitivity across different filesystems), we still want to support older packages and match npm's behavior.

Description of changes:

  • Similarly to #10208, this adjusts the regex to accept uppercase characters (A-Z) and adds a conditional that checks case sensitivity and throws a warning.
  • Adds three tests for warnings.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant