chore: add e2e and integ tests for web-search connector#1711
Open
nborges-aws wants to merge 1 commit into
Open
chore: add e2e and integ tests for web-search connector#1711nborges-aws wants to merge 1 commit into
nborges-aws wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
agentcore-harness-reviewing
agentcore-devx-automation
Bot
added
the
claude-security-reviewing
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
Contributor
Package TarballHow to installgh release download pr-1711-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.23.0.tgz |
agentcore-cli-automation
approved these changes
Jul 8, 2026
agentcore-cli-automation
left a comment
agentcore-cli-automation
left a comment
There was a problem hiding this comment.
LGTM. Test-only PR that re-adds e2e and integ suites for the web-search connector, refactored for the current --type connector --connector web-search shape and the configurations[] output schema.
Verified:
- No excessive mocking — tests use real temp projects and shell out to the real CLI.
- Telemetry helper is used at the correct boundaries (add and remove success paths).
- Config assertions match the current translator output (
parameterValues: {},parameterOverrides: [],configurations[0].name === 'WebSearch',domainFilter.exclude). - Negative paths cover repeated
--exclude-domains, wrong connector, removed--type web-searchalias, and duplicate names. - E2E cleanup is safe when
canRunis false (testDirandprojectPathguarded), and the region env var is restored inafterAll.
Non-blocking observation: the previous version of web-search-lifecycle.test.ts had a comment above the region pin explaining that "Web search is only available in us-east-1" — that comment was dropped in this refactor. Might be worth adding back so a future maintainer doesn't remove the override thinking it's unnecessary. Not a merge blocker.
github-actions
Bot
removed
the
agentcore-harness-reviewing
Contributor
Coverage Report
|
notgitika
approved these changes
Jul 8, 2026
| import { afterAll, beforeAll, describe, expect, it } from 'vitest'; | ||
|
|
||
| const hasAws = hasAwsCredentials(); | ||
| const canRun = prereqs.npm && prereqs.git && prereqs.uv && hasAws; |
Contributor
There was a problem hiding this comment.
nit: this has prereqs uv but the project is created with --skip-python-setup --no-agent so it might not be needed
jariy17
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add back integ and e2e test suite for web search, refactored to match latest connector devEx and config output schema.
Related Issue
Closes #
Documentation PR
Type of Change
Testing
How have you tested the change?
npm run test:unitandnpm run test:integnpm run typechecknpm run lintsrc/assets/, I rannpm run test:update-snapshotsand committed the updated snapshotsChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.