Migrate to AWS SDK v2, remove build tag requirements, always-on logging#238
Open
osmin-lazo wants to merge 1 commit into
Open
Migrate to AWS SDK v2, remove build tag requirements, always-on logging#238osmin-lazo wants to merge 1 commit into
osmin-lazo wants to merge 1 commit into
Conversation
- Migrate all packages from aws-sdk-go v1 to aws-sdk-go-v2 - Remove -tags logging/callback/scheduler build tag requirements - Logging is now always enabled (deleted *_notag.go files) - Replace session.Session with aws.Config (handler.Request.Config) - Replace cloudwatchiface/cloudformationiface with explicit interfaces - Fall back to stdout when ProviderLogGroupName is empty - Update Go minimum version to 1.21 Breaking changes: - handler.Request.Session (*session.Session) -> handler.Request.Config (*aws.Config) - credentials.SessionFromCredentialsProvider -> credentials.ConfigFromCredentialsProvider - No longer requires -tags logging to enable CloudWatch logging Fixes aws-cloudformation#187
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking changes:
Fixes #187, #224, #237
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.