Skip to content

chore: use pnpm 11#270

Merged
tstirrat15 merged 1 commit into
mainfrom
tstirrat/use-pnpm-11
May 13, 2026
Merged

chore: use pnpm 11#270
tstirrat15 merged 1 commit into
mainfrom
tstirrat/use-pnpm-11

Conversation

@tstirrat15
Copy link
Copy Markdown
Contributor

Description

Part of hardening our security posture.

Changes

  • Use pnpm instead of yarn
  • Update workflows accordingly
  • Move from eslint to oxlint and fix some warnings

Testing

Review.

@tstirrat15 tstirrat15 requested a review from a team as a code owner May 13, 2026 20:29
@tstirrat15 tstirrat15 force-pushed the tstirrat/use-pnpm-11 branch 4 times, most recently from e278929 to 9b0aa33 Compare May 13, 2026 22:16
@tstirrat15 tstirrat15 force-pushed the tstirrat/use-pnpm-11 branch from 9b0aa33 to 3331987 Compare May 13, 2026 22:25
Copy link
Copy Markdown
Contributor Author

@tstirrat15 tstirrat15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

strategy:
matrix:
node-version: [18, 20, 22]
node-version: [22, 24, 26]
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change reflects the currently-active versions according to node's website.

Comment thread src/types.ts
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were called out by oxlint

Comment thread pnpm-lock.yaml
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is new - I removed yarn.lock at some point in the past, but pnpm's documentation recommends committing lockfiles even for library code for the purposes of CI stability.

Comment thread .gitignore
node_modules
dist

# Because of how node's dependency management works,
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing these ignores because we're re-adding pnpm's lockfile

@tstirrat15 tstirrat15 merged commit 472b542 into main May 13, 2026
13 of 14 checks passed
@tstirrat15 tstirrat15 deleted the tstirrat/use-pnpm-11 branch May 13, 2026 22:32
@github-actions github-actions Bot locked and limited conversation to collaborators May 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants