Add jakarta support through bytecode transformation#157
Closed
luckpoint wants to merge 6 commits into
Closed
Conversation
…Eclipse Transformer - Add Eclipse Transformer integration to generate jakarta-compatible JAR - Publish both javax and jakarta versions with classifier - Update build configuration for dual artifact generation - Add Jakarta test source set for compatibility testing - Update README with installation instructions for both environments - Bump version to 1.12.0
* Implement Jakarta servlet API tests
Contributor
|
Hi @luckpoint Thank you for this, it's a thoughtful and thorough contribution. The Eclipse Transformer approach and accompanying tests made it easy to understand, and we appreciate the effort you put into it. We’ve decided to go in a different direction for Jakarta support and released 2.0.0-beta.0, which fully migrates to jakarta.servlet namespace and Java 17+ Because of that, we won’t be moving forward with this approach, so I’ll close the PR. If you get a chance to try the beta, we'd love your feedback: https://github.com/auth0/auth0-java-mvc-common/releases/tag/2.0.0-beta.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR introduces comprehensive Jakarta EE support for the auth0-java-mvc-common library through Eclipse Transformer-based bytecode transformation. This enables the library to work seamlessly with both traditional Java EE (javax.servlet) and modern Jakarta EE (jakarta.servlet) environments without requiring separate codebases.
Key Changes:
Build System Enhancements:
src/testJakarta/)performJakartaTransformationandtransformJarToJakartaGradle tasksjakarta.servlet-api:5.0.0Test Coverage:
JakartaCompatibilityTest.javato verify Jakarta EE servlet API compatibilityHttpServletRequest,HttpServletResponse,HttpSession, andCookieJakarta classestestJakartatask to run Jakarta-specific tests with transformed bytecodeDistribution:
jakartaclassifier)Documentation:
Classes and Methods Added:
JakartaCompatibilityTestclass with Jakarta servlet API verification testsperformJakartaTransformation,transformJarToJakarta,testJakartabuild.gradleEndpoints/APIs:
mvc-auth-commons:1.12.0:jakartaReferences
Testing
This change has been thoroughly tested to ensure compatibility across both servlet environments:
This change adds test coverage
JakartaCompatibilityTestwith comprehensive Jakarta servlet API testsThis change has been tested on the latest version of Java or why not
Manual Testing:
Checklist