fix(api): allow passing data with delete calls#1471
Open
ewanharris wants to merge 2 commits intoauth0:mainfrom
Open
fix(api): allow passing data with delete calls#1471ewanharris wants to merge 2 commits intoauth0:mainfrom
ewanharris wants to merge 2 commits intoauth0:mainfrom
Conversation
DELETE calls do accept a body, for example the delete memebrs from org endpoint. So we should allow it
There was a problem hiding this comment.
Pull request overview
This PR updates the api CLI command input validation to permit JSON request bodies on DELETE requests (needed for Auth0 Management API endpoints like “delete organization members”).
Changes:
- Allow
validateAndSetDatato parse/set JSON payloads forDELETE(still skippingGET). - Add a test case covering parsing of a
DELETEcall that includes the--dataflag.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
internal/cli/api.go |
Removes the DELETE early-return so JSON payloads can be parsed and sent with DELETE requests. |
internal/cli/api_test.go |
Adds a new test case for DELETE + --data argument parsing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ramya18101
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 Changes
Changes the
validateAndSetDatafunc inauth0 apito allow setting data on aDELETEcall. This is so that calls like delete org members can work.📚 References
https://auth0.com/docs/api/management/v2/organizations/delete-members
🔬 Testing
Tested calling the delete org members with the change and it works
📝 Checklist