Harden ACP parity behavior

[Finesssee]

Summary

• harden ACP cancellation so active tools are finalized as cancelled before cleanup
• add frontend regression coverage for cancellation, backend cancel invocation, and late-event suppression
• add Rust ACP session bootstrap fallback tests based on Zed-referenced behavior
• include GoalBuddy receipts documenting the Zed comparison and tranche audit

Verification

• bunx vp test run src/features/ai/tests/acp-cancellation.test.ts src/features/ai/tests/acp-activity-groups.test.ts
• bunx vp test run src/features/ai/tests
• bun typecheck
• cargo test -p athas-ai acp::bridge_init
• cargo check -p athas-ai
• cargo fmt -p athas-ai --check
• node /Users/sw/.codex/skills/goalbuddy/scripts/check-goal-state.mjs docs/goals/athas-acp-zed-parity/state.yaml
• git diff --check

Note

• bun check:rust is blocked by unrelated repo-wide rustfmt diffs outside this slice: crates/runtime/src/lib.rs, crates/tooling/src/registry.rs, and crates/tooling/src/types.rs. Scoped Rust checks for the touched crate passed.

[mehmetozguldev]

Thanks, the ACP cancellation and permission hardening direction looks good.

Before merging, I’d like two changes:

1. Don’t replace the legacy marketplace agent catalog when the ACP registry loads successfully. Please merge registry agents with the existing Athas marketplace agents, or preserve the legacy list as a fallback when the registry is incomplete. Otherwise existing agent options can disappear just because the new registry is reachable.
2. Please remove the GoalBuddy docs/goals/... state/receipt files from this PR. They include local process details and paths, but don’t belong in the product repo.

After that, this should be safe to re-check.

[mehmetozguldev]

Still waiting on this one

2. Please remove the GoalBuddy docs/goals/... state/receipt files from this PR. They include local process details and paths, but don’t belong in the product repo.

[Finesssee]

Fixed in bc96313. I removed the GoalBuddy docs/goals artifacts from this branch and verified they are no longer present in the PR diff.

Checks:

• gh pr diff 673 --name-only | rg '^docs/goals/' returns no files
• gh pr view 673 --json files --jq '.files[].path' | rg '^docs/goals/' returns no files

The remaining local docs/goals state is untracked private workspace state only and is not part of this PR.

[Finesssee]

Superseded by #682. I merged this branch into the ACP runtime/catalog branch with the newer #682 implementation kept for the conflicting runtime files, while preserving the extra ACP client/harness coverage. That removes the future conflict between this older PR and the current ACP work.

[Finesssee]

Closing as superseded by #682, which now includes the preserved coverage from this PR without the old conflicting runtime implementation.