fix: add dump_to_native fallback for migration defaults when safe#768
Open
CaydenLords wants to merge 1 commit into
Open
fix: add dump_to_native fallback for migration defaults when safe#768CaydenLords wants to merge 1 commit into
CaydenLords wants to merge 1 commit into
Conversation
zachdaniel
reviewed
May 28, 2026
|
|
||
| :error -> | ||
| EctoMigrationDefault.to_default(value) | ||
| case migration_default_from_dump(type, Map.get(attr, :constraints, []), value) do |
Contributor
There was a problem hiding this comment.
🤔 looking at this, I think this may unfortunately be a breaking change. I actually don't think we can/should do this. We have a callback available in AshPostgres.Type now like so:
@callback value_to_postgres_default(Ash.Type.t(), Ash.Type.constraints(), term) ::
{:ok, String.t()} | :errorThis may not have been available when the person submitted that issue. So I think instead we should update our documentation in an appropriate place to explain this callback and then close the corresponding issue. Would you mind finding a good place to emphasize this callback?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Leave anything that you believe does not apply unchecked.
Fixes #527