Refactor lspecIO for memory efficiency and add test suite#72
Merged
johnchandlerburnham merged 2 commits intomainfrom Mar 4, 2026
Merged
Refactor lspecIO for memory efficiency and add test suite#72johnchandlerburnham merged 2 commits intomainfrom
johnchandlerburnham merged 2 commits intomainfrom
Conversation
Replace for-loop iteration in lspecIO with tail-recursive helpers (runSuites/runTests) over a plain List, allowing Lean's reference counting to free each TestSeq after it finishes running. Compute map.size before converting to a list so the HashMap can be freed before the long-running test execution begins. Add a comprehensive test suite (27 tests across 8 suites) runnable via `lake test`, covering runIO basics, grouping, IO tests, combinators, append, property tests, lspecIO integration, and lspecEachIO. Includes an opt-in memory stress suite (`lake test -- memory`) that allocates 50 × 100MB to verify RSS stays bounded.
arthurpaulino
approved these changes
Feb 19, 2026
Member
arthurpaulino
left a comment
arthurpaulino
left a comment
There was a problem hiding this comment.
Would it make sense to run lake test on CI?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace for-loop iteration in lspecIO with tail-recursive helpers (runSuites/runTests) over a plain List, allowing Lean's reference counting to free each TestSeq after it finishes running. Compute map.size before converting to a list so the HashMap can be freed before the long-running test execution begins.
Add a comprehensive test suite (27 tests across 8 suites) runnable via
lake test, covering runIO basics, grouping, IO tests, combinators, append, property tests, lspecIO integration, and lspecEachIO. Includes an opt-in memory stress suite (lake test -- memory) that allocates 50 × 100MB to verify RSS stays bounded.