Skip to content

feat: Command Line SDK update for version 19.2.0#304

Merged
ChiragAgg5k merged 2 commits intomasterfrom
dev
Apr 28, 2026
Merged

feat: Command Line SDK update for version 19.2.0#304
ChiragAgg5k merged 2 commits intomasterfrom
dev

Conversation

@ChiragAgg5k
Copy link
Copy Markdown
Member

@ChiragAgg5k ChiragAgg5k commented Apr 28, 2026

This PR contains updates to the Command Line SDK for version 19.2.0.

@ChiragAgg5k ChiragAgg5k changed the title feat: Command Line SDK update for version 19.2.0 feat: SDK update for version 19.2.0 Apr 28, 2026
@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented Apr 28, 2026

Greptile Summary

This PR bumps the CLI to v19.2.0, shipping three main changes: a new completion command with zsh/bash/fish support, an improved Homebrew update path that auto-detects the installed formula (including third-party taps), and a fix to the standalone update-check URL (now correctly pointing at appwrite/sdk-for-cli). All three features are well-structured with appropriate fallback/degradation paths.

Confidence Score: 5/5

Safe to merge; only P2 findings present

No P0 or P1 issues found. The two P2 findings (incomplete global-option handling in isCompletionInvocation and an unquoted shell variable) are cosmetic/style concerns that don't affect correctness of the shipped features.

lib/completions.ts — the findTopLevelCommandArg edge case around space-separated global option values is worth a follow-up

Important Files Changed

Filename Overview
lib/completions.ts New file implementing shell completion for zsh, bash, and fish; findTopLevelCommandArg doesn't account for all space-consuming global options, causing isCompletionInvocation() to misfire in edge cases
lib/commands/update.ts Refactored to detect the installed Homebrew formula and use it for upgrade/version-check, with a recommendation hint when a non-official tap is detected; logic is sound
lib/utils.ts Added getInstalledHomebrewFormula via brew list --formula --full-name, with priority logic for official tap then tap-match fallback; handles third-party taps correctly
cli.ts Wires up completion command, skips update-notice and migrate() hook for completion invocations; migrate signature confirmed to take no args so the refactor is correct
install.sh Adds installCompletions step (step 4/5) with graceful degradation on failure; unquoted $APPWRITE_EXECUTABLE_FILEPATH is a minor style concern
lib/constants.ts Version bump to 19.2.0 and corrects GITHUB_REPO from legacy appwrite/appwrite-cli to appwrite/sdk-for-cli
install.ps1 Version bump of download URLs from 19.1.0 to 19.2.0; straightforward change
scoop/appwrite.config.json Version and download URLs bumped to 19.2.0; no hashes present (consistent with prior version)

Reviews (2): Last reviewed commit: "chore: update Command Line SDK to 19.2.0" | Re-trigger Greptile

Comment thread lib/completions.ts
Comment thread lib/utils.ts
@ChiragAgg5k ChiragAgg5k changed the title feat: SDK update for version 19.2.0 feat: Command Line SDK update for version 19.2.0 Apr 28, 2026
@ChiragAgg5k ChiragAgg5k merged commit 532794e into master Apr 28, 2026
2 checks passed
@ChiragAgg5k ChiragAgg5k deleted the dev branch April 28, 2026 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants