You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR bumps the CLI to v19.2.0, shipping three main changes: a new completion command with zsh/bash/fish support, an improved Homebrew update path that auto-detects the installed formula (including third-party taps), and a fix to the standalone update-check URL (now correctly pointing at appwrite/sdk-for-cli). All three features are well-structured with appropriate fallback/degradation paths.
Confidence Score: 5/5
Safe to merge; only P2 findings present
No P0 or P1 issues found. The two P2 findings (incomplete global-option handling in isCompletionInvocation and an unquoted shell variable) are cosmetic/style concerns that don't affect correctness of the shipped features.
lib/completions.ts — the findTopLevelCommandArg edge case around space-separated global option values is worth a follow-up
Important Files Changed
Filename
Overview
lib/completions.ts
New file implementing shell completion for zsh, bash, and fish; findTopLevelCommandArg doesn't account for all space-consuming global options, causing isCompletionInvocation() to misfire in edge cases
lib/commands/update.ts
Refactored to detect the installed Homebrew formula and use it for upgrade/version-check, with a recommendation hint when a non-official tap is detected; logic is sound
lib/utils.ts
Added getInstalledHomebrewFormula via brew list --formula --full-name, with priority logic for official tap then tap-match fallback; handles third-party taps correctly
cli.ts
Wires up completion command, skips update-notice and migrate() hook for completion invocations; migrate signature confirmed to take no args so the refactor is correct
install.sh
Adds installCompletions step (step 4/5) with graceful degradation on failure; unquoted $APPWRITE_EXECUTABLE_FILEPATH is a minor style concern
lib/constants.ts
Version bump to 19.2.0 and corrects GITHUB_REPO from legacy appwrite/appwrite-cli to appwrite/sdk-for-cli
install.ps1
Version bump of download URLs from 19.1.0 to 19.2.0; straightforward change
scoop/appwrite.config.json
Version and download URLs bumped to 19.2.0; no hashes present (consistent with prior version)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains updates to the Command Line SDK for version 19.2.0.