Add deep extent tree support (depth >= 2) in EXT4 formatter#650
Open
gbfish wants to merge 1 commit intoapple:mainfrom
Open
Add deep extent tree support (depth >= 2) in EXT4 formatter#650gbfish wants to merge 1 commit intoapple:mainfrom
gbfish wants to merge 1 commit intoapple:mainfrom
Conversation
Member
|
Thanks for the work. To me, would you be open to merging the two changes into one? It'd be simpler to look for logical bugs if the formatter and reader are all in one. |
843b8ae to
b60c975
Compare
3 tasks
Author
|
Done — combined both reader and formatter changes into this single PR. Thanks for the suggestion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getExtents()with recursivereadExtentNode()that handles any depthwriteExtentSubtree()that recursively builds extent trees of any depthleafNode.leaves.last!.block(use safe optional access).loadLittleEndian(as:)for all on-disk struct reads