Fix: bad request will remove header and retry login#429
Closed
tico88612 wants to merge 1 commit intoapple:mainfrom
Closed
Fix: bad request will remove header and retry login#429tico88612 wants to merge 1 commit intoapple:mainfrom
tico88612 wants to merge 1 commit intoapple:mainfrom
Conversation
3 tasks
Member
|
Hi @tico88612, thanks! Please run |
tico88612
force-pushed
the
fix/bad-request-remove-auth
branch
from
1ce6c9d to
dae001e
Compare
Contributor
Author
|
@dcantah Oh, I forgot it. Done. |
tico88612
force-pushed
the
fix/bad-request-remove-auth
branch
3 times, most recently
from
45ec596 to
51ebf50
Compare
tico88612
force-pushed
the
fix/bad-request-remove-auth
branch
from
51ebf50 to
56712fe
Compare
Contributor
Author
|
Friendly ping @dcantah What do you think about this PR? |
If you're requesting on /v2/ with basic auth, AWS ECR will return 400 Bad Request and won't provide www-authenticate information. Retry the request after removing the Authorization header. Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
tico88612
force-pushed
the
fix/bad-request-remove-auth
branch
from
56712fe to
0d9c991
Compare
Contributor
|
Thanks for the fix. When you have time again, can you rebase and open a new PR. We will prioritize getting it merged in. Thanks! |
Contributor
Author
|
The new PR is here (#711) and I've already rebased it. I hope it won't take too much longer again. Thanks! |
crosbymichael
pushed a commit
that referenced
this pull request
Apr 29, 2026
If you're requesting on `/v2/` with basic auth, AWS ECR will return 400 Bad Request and won't provide `www-authenticate` information. Retry the request after removing the Authorization header. Continue PR #429 Fixed apple/container#847 Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you're requesting on
/v2/with basic auth, AWS ECR will return 400 Bad Request and won't providewww-authenticateinformation.Retry the request after removing the Authorization header.
Fixed apple/container#847