Conversation
The first urlparse call was unconditionally overwritten by a second call with public=True. Drop it so async mirrors the sync version and so nobody gets tripped up by the non-public URL being silently shadowed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
vdusek
added
adhoc
vdusek
changed the title
urlparse in async create_keys_public_url
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #750 +/- ##
==========================================
+ Coverage 95.45% 95.53% +0.07%
==========================================
Files 45 45
Lines 5125 5124 -1
==========================================
+ Hits 4892 4895 +3
+ Misses 233 229 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pijukatel
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The async
KeyValueStoreClientAsync.create_keys_public_urlassignedkeys_public_url = urlparse(self._build_url('keys'))early in the method, but this value was unconditionally overwritten later byurlparse(self._build_url('keys', public=True)). The sync counterpart only has the single correct call — this was an asymmetric refactor artifact.No behavior change: the second assignment always won. Removing the dead call eliminates a small wasted
_build_url/urlparseon every call and removes a latent foot-gun where code inserted between the two assignments would silently see the non-public URL.