Draft: Centralize Input/Output and Data Class Logic in Metadata#7908
Closed
Cafeine42 wants to merge 5 commits into
Closed
Draft: Centralize Input/Output and Data Class Logic in Metadata#7908Cafeine42 wants to merge 5 commits into
Cafeine42 wants to merge 5 commits into
Conversation
Cafeine42
force-pushed
the
input-output-idea
branch
3 times, most recently
from
def8e4e to
7766881
Compare
Cafeine42
force-pushed
the
input-output-idea
branch
2 times, most recently
from
bea6c55 to
4506f77
Compare
Cafeine42
force-pushed
the
input-output-idea
branch
from
4506f77 to
ac1b635
Compare
Member
|
I don't understand what are you trying to achieve? |
Contributor
Author
|
Replace by #8338 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ould we store string-class|null directly instead of an array that may contain class?
Does getClass become unnecessary? We still need input/output/data, which could default to the API resource class when undefined.