fix: move isCacheKeySafe from GraphQL to AbstractItemNormalizer#7854
Open
tillmon wants to merge 1 commit intoapi-platform:4.3from
Open
fix: move isCacheKeySafe from GraphQL to AbstractItemNormalizer#7854tillmon wants to merge 1 commit intoapi-platform:4.3from
tillmon wants to merge 1 commit intoapi-platform:4.3from
Conversation
Member
|
Isn't cache key handled differently on other formats? could you target at least 4.3 ? |
tillmon
force-pushed
the
fix/cache-key-security-all-formats
branch
from
c6c0701 to
57e3a0f
Compare
tillmon
force-pushed
the
fix/cache-key-security-all-formats
branch
from
57e3a0f to
e7874bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
isCacheKeySafe()logic already exists in the GraphQL normalizer but is not applied to other formats. Move cache key safety logic toAbstractItemNormalizerto prevent attribute cache leaks across users.AbstractObjectNormalizer::$attributesCacheis not user-aware, but#[ApiProperty(security: ...)]makes allowed attributes depend on the current user.Relates to #5686