ZOOKEEPER-5061 ZooKeeper website fixes#2413
Conversation
|
Added a few more changes. |
|
I think the "IRC Channel" page could be replaced with ASF Slack information, because IRC is no longer maintained. Workspace: https://the-asf.slack.com/ |
|
Tests with Ignore that. You already listed the supported Node versions in the Readme. 👍 |
phunt
left a comment
phunt
left a comment
There was a problem hiding this comment.
lgtm - the issue of http->https is a good fix. we should do this across the codebase (separate jira/pr)
|
|
||
| Full documentation for this release can also be found in ../../docs/index.html | ||
| Full documentation for this release can also be found at: | ||
| https://zookeeper.apache.org/doc/current/ |
There was a problem hiding this comment.
I'm not sure - but shouldn't all references be local given the doc relative to this reference is in this code base and should be used (could be updated as part of a change) rather than pointing to the release version on the website? Similar comment for all the relative -> absolute/web conversions in this commit.
There was a problem hiding this comment.
I can make it local, but it's probably not going to work like it used to be. Currently we don't have some index.html that's a source and output at the same time. We got .mdx files and they are rendered by JS into html files at build time, so we don't have "ready" pages to be viewed right away anymore.
| "3.9.4", | ||
| "3.9.5", | ||
| CURRENT_VERSION | ||
| ] as const; |
There was a problem hiding this comment.
Do we need to maintain this list in the future by adding new releases?
Why don't we just link to https://zookeeper.apache.org/doc/ which lists all the available archived docs?
| export const LTS_VERSIONS: ReleasedDocVersion[] = [ | ||
| CURRENT_VERSION, | ||
| "3.9.5", | ||
| "3.8.6" |
There was a problem hiding this comment.
Given that we're going to publish this website with 3.9.5 as the current version, I think this list should be:
- CURRENT_VERSION
- 3.8.6
- 3.7.2
In order to mirror old website content.
3 participants
Here are the website fixes to issues/bugs addressed by @phunt and @anmolnar
I also added an updated
README.mdfile to this PR, so it's easier to review for everyone. Once the PR is approved, I will remove it and @anmolnar will update the wiki page. The file describes how the update and release flows of the website happen. I tried to write in as much detail as possible.Thanks.