ZOOKEEPER-4324: dropwizard-metrics should be optional#2402
Open
dsmiley wants to merge 3 commits into
Open
Conversation
maoling
approved these changes
Jun 26, 2026
maoling
left a comment
maoling
left a comment
Member
There was a problem hiding this comment.
This PR fixes an issue where external projects (e.g. Solr) could still encounter ClassNotFoundException or build failures even after excluding Dropwizard and configuring metricsProvider.className=org.apache.zookeeper.metrics.impl.NullMetricsProvider.
I tested this change with PrometheusMetricsProvider, DefaultMetricsProvider, and NullMetricsProvider, and all three configurations work as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://issues.apache.org/jira/browse/ZOOKEEPER-4324
I verified this change in Solr -- I was able to start Solr in SolrCloud mode with the following setting in its
zoo.cfg:metricsProvider.className=org.apache.zookeeper.metrics.impl.NullMetricsProviderIdeally I'd add an "ArchUnit" test as well, as I did in #2374