decode digest auth data as UTF-8 in handleAuthentication#2399
Open
jmestwa-coder wants to merge 1 commit into
Open
decode digest auth data as UTF-8 in handleAuthentication#2399jmestwa-coder wants to merge 1 commit into
jmestwa-coder wants to merge 1 commit into
Conversation
jmestwa-coder
force-pushed
the
digest-auth-utf8
branch
from
0a2b343 to
1ac6bd2
Compare
Author
|
the only ci run errored before it actually built (jenkins reported "this commit cannot be built"), so i rebased on current master to retrigger it. no change beyond the original one-line utf-8 decode. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handleAuthentication decodes the incoming auth bytes with new String(authData), which uses the platform default charset, while digest() hashes the credential with getBytes(UTF_8). On a JVM whose default charset is not UTF-8, a credential with non-ASCII characters then hashes to a different value than the one generateDigest produced for the matching ACL, so the digest id stops matching and auth fails. Decode as UTF_8 so both paths agree.