ZOOKEEPER-5023: Allow to set TLS version and ciphers for AdminServer#2365
Closed
PDavid wants to merge 1 commit intoapache:branch-3.8from
Closed
ZOOKEEPER-5023: Allow to set TLS version and ciphers for AdminServer#2365PDavid wants to merge 1 commit intoapache:branch-3.8from
PDavid wants to merge 1 commit intoapache:branch-3.8from
Conversation
Contributor
Author
|
This is a backport of #2359 for branch-3.8. The patch did no applied cleanly, I had to resolve conflicts in TestingI tested this locally the same way as in the original: Restrict TLS version to 1.2, and ciphers to call with curl: |
PDavid
commented
Mar 24, 2026
Comment on lines
+2569
to
+2587
| ##### Configuring AdminServer for SSL/TLS | ||
| - Generating the **keystore.jks** and **truststore.jks** which can be found in the [Quorum TLS](#Quorum+TLS). | ||
| - Add the following configuration settings to the `zoo.cfg` config file: | ||
|
|
||
| ``` | ||
| admin.portUnification=true | ||
| ssl.quorum.keyStore.location=/path/to/keystore.jks | ||
| ssl.quorum.keyStore.password=password | ||
| ssl.quorum.trustStore.location=/path/to/truststore.jks | ||
| ssl.quorum.trustStore.password=password | ||
| ``` | ||
| - Verify that the following entries in the logs can be seen: | ||
|
|
||
| ``` | ||
| 2019-08-03 15:44:55,213 [myid:] - INFO [main:JettyAdminServer@123] - Successfully loaded private key from /data/software/cert/keystore.jks | ||
| 2019-08-03 15:44:55,213 [myid:] - INFO [main:JettyAdminServer@124] - Successfully loaded certificate authority from /data/software/cert/truststore.jks | ||
|
|
||
| 2019-08-03 15:44:55,403 [myid:] - INFO [main:JettyAdminServer@170] - Started AdminServer on address 0.0.0.0, port 8080 and command URL /commands | ||
| ``` |
Contributor
Author
There was a problem hiding this comment.
This section was already present in master, since this branch also supports AdminServer with TLS, so it is relevant and useful here, I added it here.
Reviewers: meszibalu, anmolnar Author: PDavid Closes apache#2359 from PDavid/ZOOKEEPER-5023-AdminServer-TLS-proto-ciphers (cherry picked from commit eab1659)
d7e168f to
2847c8f
Compare
Contributor
Author
|
Closing this because there is no need to backport this to 3.8 because this is not a security fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reviewers: meszibalu, anmolnar
Author: PDavid
Closes #2359 from PDavid/ZOOKEEPER-5023-AdminServer-TLS-proto-ciphers
(cherry picked from commit eab1659)