[Frontend][TFLite] Add test coverage for SHAPE and RANGE operators#19401
Open
rknastenka wants to merge 4 commits intoapache:mainfrom
Open
[Frontend][TFLite] Add test coverage for SHAPE and RANGE operators#19401rknastenka wants to merge 4 commits intoapache:mainfrom
rknastenka wants to merge 4 commits intoapache:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request enhances the TFLite frontend for Relax by implementing support for the SHAPE and RANGE operators. It also updates subgraph processing to allow zero inputs and improves output resolution to correctly handle constant or prefetched tensors. The review feedback identifies opportunities to simplify the code by removing redundant type checks in the RANGE operator implementation and omitting an unnecessary cast to int64 for SHAPE outputs, given the default behavior of the underlying operator.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Member
|
Hi @rknastenka ,could you resolve the conflict so that we can merge it:) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial goal was to add SHAPE and RANGE tests, solving part of #18971
This PR achieves that and includes the minimum necessary frontend fixes discovered during implementation so those tests reflect real supported behavior instead of xfail/workarounds.
so this PR includes both:
1. New SHAPE/RANGE tests
2. Targeted frontend fixes required to make those tests pass correctly
Why These Changes Were Needed
Modifications
Frontend Changes (In tflite_frontend.py):
Main functional changes are localized to SHAPE/RANGE conversion and model output/input handling.