Validate m_frag_offset_count and offset during cache unmarshal#13165
Open
traeak wants to merge 4 commits into
Open
Validate m_frag_offset_count and offset during cache unmarshal#13165traeak wants to merge 4 commits into
traeak wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds bounds validation when unmarshaling HTTP cache alternates to guard against corrupted on-disk data triggering out-of-buffer reads via m_frag_offset_count or the embedded fragment-offset pointer.
Changes:
- Validate
m_frag_offset_countand the encoded fragment-offset position against both remaining length and original buffer length inHTTPInfo::unmarshal. - Apply analogous validation in
HTTPInfo::unmarshal_v24_1using the "extra beyond integral slots" size. - Return -1 (with assertion) on validation failure instead of proceeding with invalid sizes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an overflow check in case of cache device corruption.