Skip to content

Add various tests#969

Merged
dsoumis merged 6 commits intoapache:mainfrom
dsoumis:perf
Mar 29, 2026
Merged

Add various tests#969
dsoumis merged 6 commits intoapache:mainfrom
dsoumis:perf

Conversation

@dsoumis
Copy link
Copy Markdown
Member

@dsoumis dsoumis commented Mar 27, 2026

No description provided.

@rmaucher
Copy link
Copy Markdown
Contributor

I'm not a big fan of adding the dependency to the main TesterSupport class. Maybe move it somewhere else.
Also usually we use static certificates but of course the strategy doesn't scale indefinitely.

@dsoumis
Copy link
Copy Markdown
Member Author

dsoumis commented Mar 27, 2026

I'm not a big fan of adding the dependency to the main TesterSupport class. Maybe move it somewhere else. Also usually we use static certificates but of course the strategy doesn't scale indefinitely.

I was thinking that would be beneficial if we had a certificate generation method programmatically in the main helper class. The reason I didn't use a static certificate for the test, was exactly this; the ability to create one programmatically through BouncyCastle and avoid adding extra resources to the repo.

@rmaucher
Copy link
Copy Markdown
Contributor

Maybe. Is it fast ?
OTOH, it will work without the dependency if the code is not used at all (= test is skipped).

@dsoumis
Copy link
Copy Markdown
Member Author

dsoumis commented Mar 27, 2026

Definitely not slow.
I see the point, I will create a new class with that utility so the rest of the tests can be ran independently.

@dsoumis dsoumis merged commit 722464b into apache:main Mar 29, 2026
6 checks passed
@dsoumis dsoumis deleted the perf branch March 29, 2026 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants