TikaFix ---Contribution by jerni-zu393#185
TikaFix ---Contribution by jerni-zu393#185jerni-zu393 wants to merge 2 commits intoapache:masterfrom
Conversation
…, *.aac). It can be detect the file types even the files should not have "."extensions .
…, *.aac). It can be detect the file types even the files should not have "."extensions .
jerni-zu393
changed the title
|
Any updates ? |
|
@Gagravarr any objections? Would be useful to open a ticket on our JIRA to track to this. Also would be helpful to add unit tests with files that you've provided. Thank you! |
|
The keystore one should probably go further down the file, so it's in alphabetical order as the others are For APC files, do we know if they always store the entries in that specific order? Or if it might change? Currently The AAC file magic with ID3 at the front doesn't necessarily look right to me - won't most MP3 files with ID3 tags in first incorrectly match on this too? |
| <match value="P" type="string" offset="2"> | ||
| <match value="libfaac" type="string" offset="11"/> | ||
| </match> | ||
| </magic> |
There was a problem hiding this comment.
where is this detection coming from? I cannot find it the same in the file util nor looking around.. my AAC file starts with FFF1 which is kind of indicated in https://www.garykessler.net/library/file_sigs.html as an example
4 participants
I have added the magic bits for three files (*.keystore/.jks , *.apk , *.aac). It can be detect the file types even the files should not have "."extensions .
I have attached here below the sample files for testing purpose .
keystore.tar.gz
apktest.zip
aactest.zip