fix(release): use consistent 7-char commit hash for image tags#4231
Open
bobbai00 wants to merge 1 commit intoapache:mainfrom
Open
fix(release): use consistent 7-char commit hash for image tags#4231bobbai00 wants to merge 1 commit intoapache:mainfrom
bobbai00 wants to merge 1 commit intoapache:mainfrom
Conversation
The build-and-push-images workflow uses `sha[:7]` (always 7 chars) to tag images, but create-release-candidate used `git rev-parse --short` which produces a variable-length hash (can be 7-12+ chars depending on repo size). This mismatch causes "manifest unknown" errors when the docker-compose bundle tries to pull images with the wrong tag. Fix by using `cut -c1-7` to always produce a 7-char hash, matching the build workflow. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Fix image tag length mismatch between the build and release workflows.
The
build-and-push-imagesworkflow tags images withsha[:7](always 7 chars), butcreate-release-candidateusedgit rev-parse --shortwhich produces a variable-length hash (can be 9+ chars). This causedmanifest unknownerrors when runningdocker compose upfrom the release bundle.The fix replaces
git rev-parse --shortwithgit rev-parse | cut -c1-7to always produce a 7-character commit hash, consistent with the build workflow.Any related issues, documentation, discussions?
Fixes #4230
How was this PR tested?
docker pull ghcr.io/apache/texera-dashboard-service:9fd356c(7-char) succeedsdocker pull ghcr.io/apache/texera-dashboard-service:9fd356c3b(9-char) fails withmanifest unknown.envlocally to use the 7-char tag and confirmed all 11 containers start successfully withdocker compose up -dWas this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 4.6)