Skip to content

[MINOR] Fix CholeskyTest crash when residual is exactly zero #2487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Baunsgaard merged 1 commit into from
Jun 9, 2026
+3 −3
Merged

[MINOR] Fix CholeskyTest crash when residual is exactly zero #2487

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/test/java/org/apache/sysds/test/functions/unary/matrix/CholeskyTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
import org.junit.Test;
import org.apache.sysds.api.DMLScript;
import org.apache.sysds.common.Types.ExecMode;
import org.apache.sysds.runtime.matrix.data.MatrixValue;
import org.apache.sysds.runtime.matrix.data.MatrixValue.CellIndex;
import org.apache.sysds.runtime.meta.MatrixCharacteristics;
import org.apache.sysds.test.AutomatedTestBase;
Expand Down Expand Up @@ -110,8 +109,9 @@ private void runTestCholesky( int rows, int cols, ExecMode rt) {
//run tests and compare results
runTest(true, false, null, -1);
HashMap<CellIndex, Double> dmlOut = readDMLMatrixFromOutputDir("D");
MatrixValue.CellIndex index = dmlOut.keySet().iterator().next();
double d = dmlOut.get(index);
// D is the 1x1 residual sum(A-B); an exact 0.0 result is not written to
// the sparse output, so an empty map corresponds to a perfect residual.
double d = dmlOut.isEmpty() ? 0.0 : dmlOut.values().iterator().next();
Assert.assertEquals(0, d, 1e-5);
}
finally {
Expand Down
Loading