[SYSTEMDS-2651] Replace fixed-sleep federated worker startup with Poll#2468
Closed
Baunsgaard wants to merge 1 commit into
Closed
[SYSTEMDS-2651] Replace fixed-sleep federated worker startup with Poll#2468Baunsgaard wants to merge 1 commit into
Baunsgaard wants to merge 1 commit into
Conversation
Baunsgaard
changed the title
…rtup Replace fixed Thread.sleep after each federated worker start with TCP port polling that returns as soon as the worker accepts a connection. Add bulk helpers that spawn N workers in parallel and wait once for the slowest to become ready, instead of summing per-worker waits. Cuts the federated CI total by ~7 min (-5%) vs main, with the biggest wins in setup-heavy suites such as transform+fedplanner (-66%) and codegen (-25%). Closes apache#2468.
Baunsgaard
force-pushed
the
FederatedWorkerReadyPolling
branch
from
8804921 to
0c830d4
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2468 +/- ##
============================================
- Coverage 71.55% 71.38% -0.17%
- Complexity 47461 48707 +1246
============================================
Files 1539 1570 +31
Lines 182631 188757 +6126
Branches 35919 37039 +1120
============================================
+ Hits 130677 134744 +4067
- Misses 41944 43571 +1627
- Partials 10010 10442 +432 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replace the thread.sleep with a poll based startup of federated workers in testing. The change helps our test suites to not have timeouts, or failures because of inconsistent launches of federated workers.