Port Clojure tests to Java: drpc_test, grouping_test (Phase 4)#8449
Open
Port Clojure tests to Java: drpc_test, grouping_test (Phase 4)#8449
Conversation
Port 7 tests from storm-core/test/clj/org/apache/storm/drpc_test.clj to storm-server/src/test/java/org/apache/storm/drpc/DRPCIntegrationTest.java: - testDrpcFlow: raw DRPCSpout + ReturnResults topology - testDrpcBuilder: LinearDRPCTopologyBuilder - testDrpcCoordination: coordinated counting with partial-count + aggregator - testDrpcCoordinationTricky: multi-stage coordination with finishedId - testDrpcFailFinish: FailedException in finishedId - testDrpcAttemptsTwoReconnectsInFailRequest: Mockito test for retry logic - testDrpcStopsRetryingAfterSuccessfulReconnect: Mockito test for retry logic Port 3 tests from storm-core/test/clj/org/apache/storm/grouping_test.clj to storm-server/src/test/java/org/apache/storm/grouping/GroupingIntegrationTest.java: - testShuffle: shuffle grouping distributes evenly - testFieldGrouping: fields grouping with TestWordBytesCounter - testCustomGroupings: NGrouping custom stream and JavaObject grouping All Clojure defbolt macros replaced with Java inner classes. Duplicate test-field in Clojure (2nd overrides 1st) resolved to single test. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
rzo1
approved these changes
Mar 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #8445
Summary
drpc_test.cljand all 3 effective tests fromgrouping_test.cljto Java/JUnit 5defboltmacros replaced with Java inner classes (8 bolt implementations)test-fieldin Clojure (2nd overrides 1st) resolved to a single testTests ported
DRPCIntegrationTest (7 tests):
testDrpcFlowtestDrpcBuildertestDrpcCoordinationtestDrpcCoordinationTrickytestDrpcFailFinishtestDrpcAttemptsTwoReconnectsInFailRequesttestDrpcStopsRetryingAfterSuccessfulReconnectGroupingIntegrationTest (3 tests):
testShuffletestFieldGroupingtestCustomGroupingsPart of the Clojure test migration effort (Phase 4 of #8445).
Test plan
mvn test -pl storm-server -Dtest="org.apache.storm.drpc.DRPCIntegrationTest,org.apache.storm.grouping.GroupingIntegrationTest"— all 10 tests passmvn test -pl storm-server🤖 Generated with Claude Code