Skip to content

[SPARK-58106][DOCS][INFRA] Remove stale references to black#57231

Open
gaogaotiantian wants to merge 2 commits into
apache:masterfrom
gaogaotiantian:fix-black-doc
Open

[SPARK-58106][DOCS][INFRA] Remove stale references to black#57231
gaogaotiantian wants to merge 2 commits into
apache:masterfrom
gaogaotiantian:fix-black-doc

Conversation

@gaogaotiantian

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Remove some stale references to black.

Why are the changes needed?

We have been moved to ruff for a while. branch-4.x and master are using ruff exclusively for formatting, not black. We need to update our docs and some dependency files.

Notice that the --black command in lint-python is also removed. That was already deprecated for a while and was kind of hidden from users. Leaving it available does not gain us anything because it will conflict with ruff. Using black will mess up the format for ruff - it's better to just remove it.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

CI - this should not have any impact on real code.

Was this patch authored or co-authored using generative AI tooling?

No.

@dongjoon-hyun dongjoon-hyun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, @gaogaotiantian . BTW, please remove this line too in order to be free of black legacy.

E203, # Skip as black formatter adds a whitespace around ':'.

@dongjoon-hyun dongjoon-hyun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM (with one comment).

@gaogaotiantian

gaogaotiantian commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

Nice, @gaogaotiantian . BTW, please remove this line too in order to be free of black legacy.

E203, # Skip as black formatter adds a whitespace around ':'.

Hi @dongjoon-hyun , thanks for noticing this! tox.ini file is also stale. It was used by flake8 which was replaced by ruff a few months ago too. We do not use flake8 anymore for pyspark. I would propose a PR soon to remove that stale file directly (and the references to flake8 too). I think it should be fine that we leave the comment in the file for this PR as the file would be removed soon?

edit: the PR is proposed - #57258

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants