[SPARK-56840][SQL][FOLLOW-UP] Add a real NullIf repro test#55883
Open
sunchao wants to merge 4 commits into
Open
[SPARK-56840][SQL][FOLLOW-UP] Add a real NullIf repro test#55883sunchao wants to merge 4 commits into
sunchao wants to merge 4 commits into
Conversation
| } | ||
| } | ||
|
|
||
| test("NullIf accepts unresolved nested fields during inlined function construction") { |
Member
There was a problem hiding this comment.
Shall we add a test prefix, SPARK-56840: ?
Contributor
There was a problem hiding this comment.
Unfortunately the ticket prefixes were missing from https://github.com/apache/spark/pull/55838/changes too, but we can add them in this follow-up.
Contributor
There was a problem hiding this comment.
Can you please add it to the 2 new tests of https://github.com/apache/spark/pull/55838/changes as well?
Member
|
cc @peter-toth |
peter-toth
approved these changes
May 14, 2026
dongjoon-hyun
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add a focused Catalyst regression test that constructs builtin
nullifwith an unresolved nested field reference whileALWAYS_INLINE_COMMON_EXPR=true. This reproduces the eagerleft.dataTypeaccess that motivated SPARK-56840 and guards the fixed construction path directly.Why are the changes needed?
The original SPARK-56840 fix was merged with an end-to-end repro that also passes without the fix, so it does not prove the bug boundary. This follow-up adds a real negative/positive regression test that fails before commit
5949ab30b41withInvalid call to dataType on unresolved objectand passes with the fix.Does this PR introduce any user-facing change?
No.
How was this patch tested?
build/sbt 'catalyst/testOnly org.apache.spark.sql.catalyst.expressions.NullExpressionsSuite -- -z "NullIf accepts unresolved nested fields during inlined function construction"'9ab8e43a940withUnresolvedException: Invalid call to dataType on unresolved objectand passes on currentapache/master.Was this patch authored or co-authored using generative AI tooling?
Generated-by: Codex