Skip to content

SOLR-18174 Fix test race condition failure in AsyncTrackerSemaphoreLeakTest #4331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
janhoy wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −1
Open

SOLR-18174 Fix test race condition failure in AsyncTrackerSemaphoreLeakTest #4331

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion solr/core/src/test/org/apache/solr/handler/component/AsyncTrackerSemaphoreLeakTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,16 @@ public void testSemaphoreLeakOnLBRetry() throws Exception {
+ " fires synchronously on the IO thread before onComplete can release().");
}

int permitsAfterFailures = testClient.asyncTrackerAvailablePermits();
// Poll briefly: apiFutures complete on the executor thread, but completeListener fires on
// Jetty's IO thread after response listeners, so allOf().get() can race ahead of release().
int permitsAfterFailures;
long deadline = System.nanoTime() + TimeUnit.SECONDS.toNanos(5);
do {
permitsAfterFailures = testClient.asyncTrackerAvailablePermits();
if (permitsAfterFailures == MAX_PERMITS) break;
//noinspection BusyWait
Thread.sleep(10);
} while (System.nanoTime() < deadline);
log.info("Permits after retries: {}/{}", permitsAfterFailures, MAX_PERMITS);
assertEquals(
"All permits should be restored after retries complete",
Expand Down
Loading